[local_auth] Convert example app to Swift #11003
Open
+421
−271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested review from
LouiseHsu and
okorohelijah
as code owners
stuartmorgan-g
added
override: no versioning needed
Collaborator
Author
|
Changelog/version override: Native example app template details are not relevant to clients. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request converts the iOS example app for local_auth_darwin from Objective-C to Swift by regenerating the project from the latest Flutter stable template, updating project files and configurations. However, a critical vulnerability was introduced: the NSFaceIDUsageDescription key is missing from the Info.plist file. This absence will cause the app to crash when attempting biometric authentication with Face ID, making the example app non-functional on supported iOS hardware. Restoring this key is essential for the app to function correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the Obj-C example app with Swift. Rather than attempt to modify the example in place, I started clean from the Swift template:
flutter create --platforms=ios .using currentstable(3.41.0).Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3